I had the problem of terrible smelling yellow discharge all my life, and had to wear panty liner for work and at home .
Drink cramberry juice.The smell will be strong for a few days until all the infection comes out. After that, no more problems. Proven by me and friends who had similar problems and drank cramberry juice. Give it a try. You will lose nothing but the cause of your problem.