Its my understanding that Colloidal Silver atoms have an indefinite shel live, however to comply with some standards they do place a limit of 3 to 4 years.
Ionic Silver made with Bromides, surly has a shelf life.
Chemical Colloids (those ugly colored ones) also have a shelf life.