There are a number of things that can cause cloudy urine, but iron does not cause white cloudiness. You do not mention anything like pain or fever so UTI or kidney stones are unlikely. Protein in the urine can cause this but usually also causes a lot of foaming, which you also did not mention so this is unlikely. So what I wold recommend is taking a sample then adding some vinegar to the sample to see if the solution goes clear. If it does then the cloudiness was from phosphate in the urine. This could be from something as simple as consuming too much phosphorus or from hyperparathyroidism or kidney issues including stones.
Couple of things to note it doesnt seem like every time i pee its cloudy, maybe about 50% of the time i urinate. I also have frequent urination, is parathyroid hormone related in anyway to ADH hormone?
No. But frequent urination can be from a number of things. Lack of ADH (vasopressin), small or spastic bladder, sugar diabetes, drinking purified waters, etc.
One last thing im currently on 2 grains of armour thyroid not sure if this has any relevance.
Only if it is speeding up your heart too much. The more blood pumped through the kidneys the more water gets removed. Same reason that we need to urinate more frequently when we are really cold or stressed.